[
https://issues.apache.org/jira/browse/FLINK-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577192#comment-14577192
]
ASF GitHub Bot commented on FLINK-2174:
---------------------------------------
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-109997612
The second example was a positive example. Trailing comments are removed
correctly. However, many different characters can be used for comments (what is
not good from my point of view):
mjsax@T420s-dbis-mjsax:~$ SLAVE="host|comment"; if [[ "$SLAVE" =~
^([0-9a-zA-Z/.-]+).*$ ]] ; then SLAVE="${BASH_REMATCH[1]}"; fi; echo $SLAVE
host
mjsax@T420s-dbis-mjsax:~$ SLAVE="host@comment"; if [[ "$SLAVE" =~
^([0-9a-zA-Z/.-]+).*$ ]] ; then SLAVE="${BASH_REMATCH[1]}"; fi; echo $SLAVE
host
mjsax@T420s-dbis-mjsax:~$ SLAVE="host comment"; if [[ "$SLAVE" =~
^([0-9a-zA-Z/.-]+).*$ ]] ; then SLAVE="${BASH_REMATCH[1]}"; fi; echo $SLAVE
host
> Allow comments in 'slaves' file
> -------------------------------
>
> Key: FLINK-2174
> URL: https://issues.apache.org/jira/browse/FLINK-2174
> Project: Flink
> Issue Type: Improvement
> Components: Start-Stop Scripts
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Trivial
>
> Currently, each line in slaves in interpreded as a host name. Scripts should
> skip lines starting with '#'. Also allow for comments at the end of a line
> and skip empty lines.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
