[
https://issues.apache.org/jira/browse/FLINK-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577196#comment-14577196
]
ASF GitHub Bot commented on FLINK-2174:
---------------------------------------
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-109998768
My bad. Sorry for bothering. I had slightly modified the example. We could,
however, just remove the if statement and it would work without creating an
external process:
```bash
[[ "hello bli blub 123 353" =~ ^([0-9a-zA-Z/.-]+).*$ ]]
SLAVE=${BASH_REMATCH[1]}
```
I agree that it is cleaner to have only one comment character. Only
disadvantage I see is that it breaks backwards-compatibility. The whole thing
needs a bit of cleanup. For example, the "network topology" seems a bit weird
and is probably a legacy feature.
> Allow comments in 'slaves' file
> -------------------------------
>
> Key: FLINK-2174
> URL: https://issues.apache.org/jira/browse/FLINK-2174
> Project: Flink
> Issue Type: Improvement
> Components: Start-Stop Scripts
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Trivial
>
> Currently, each line in slaves in interpreded as a host name. Scripts should
> skip lines starting with '#'. Also allow for comments at the end of a line
> and skip empty lines.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
