[
https://issues.apache.org/jira/browse/FLINK-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577216#comment-14577216
]
ASF GitHub Bot commented on FLINK-2174:
---------------------------------------
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/796#issuecomment-110004370
See your point. But we need to come to a conclusion.
- I like my single line comment better (of course ;)) -- I thinks it's
easier to read than any regex -- and I don't think, that the cut-process in an
issue
- the last command you suggested is taking the first matching token,
thus, there are still multiple cut-off characters
Should we start a vote?
> Allow comments in 'slaves' file
> -------------------------------
>
> Key: FLINK-2174
> URL: https://issues.apache.org/jira/browse/FLINK-2174
> Project: Flink
> Issue Type: Improvement
> Components: Start-Stop Scripts
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Trivial
>
> Currently, each line in slaves in interpreded as a host name. Scripts should
> skip lines starting with '#'. Also allow for comments at the end of a line
> and skip empty lines.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)