snuyanzin commented on code in PR #136:
URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467969251
##########
flink-shaded-zookeeper-parent/flink-shaded-zookeeper-38/pom.xml:
##########
@@ -128,6 +131,7 @@ under the License.
<groupId>org.apache.zookeeper</groupId>
<artifactId>zookeeper</artifactId>
<version>${zookeeper.version}</version>
+ <optional>${flink.markBundledAsOptional}</optional>
</dependency>
<dependency>
<groupId>io.netty</groupId>
Review Comment:
May be I was not clear enough, sorry
By saying
>it does not make sense to add it for depedencies inside dependencyManagement
I ment not in general. Just for the case here
Here there is already existing dependency on zookeeper for every zookeeper
module in dependencies which overrides the one from dependency management
(optional tag).
Netty here comes only as a dependency from zookeeper and once zookeeper is
marked optional maven started to think that netty is also becoming optional
I don't think this is the case for poms you've mentioned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
