XComp commented on code in PR #136:
URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1467765454
##########
.github/workflows/ci.yml:
##########
@@ -51,6 +52,14 @@ jobs:
- name: Check licensing
run: |
- mvn ${MVN_COMMON_OPTIONS} exec:java@check-licensing -N \
+ mvn ${MVN_COMMON_OPTIONS} exec:java@check-license -N \
-Dexec.args="${{ env.MVN_BUILD_OUTPUT_FILE }} $(pwd) ${{
env.MVN_VALIDATION_DIR }}" \
- -Dlog4j.configurationFile=file://$(pwd)/tools/ci/log4j.properties
\ No newline at end of file
+ -Dlog4j.configurationFile=file://$(pwd)/tools/ci/log4j.properties
+
+ - name: Check shade optional dependencies
+ run: |
+ mvn ${MVN_COMMON_OPTIONS} dependency:tree -Plicense-check | tee
${{ env.MVN_DEPENDENCY_PLUGIN_OUTPUT_FILE }}
Review Comment:
```
<!-- The license check and the optional shade check require the artifactId
to match the directory that the module resides in.
```
hm, ok, if that's the case we could update [the
comment](https://github.com/apache/flink-shaded/blob/392b737466b4be424873b48c0f31a999b8a34e70/pom.xml#L69)
in the parent pom file to also mention the shade checker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
