snuyanzin commented on code in PR #136:
URL: https://github.com/apache/flink-shaded/pull/136#discussion_r1468176508
##########
pom.xml:
##########
@@ -65,6 +65,7 @@ under the License.
<netty.version>4.1.100.Final</netty.version>
<jackson.version>2.15.3</jackson.version>
<guava.version>32.1.3-jre</guava.version>
+ <flink.markBundledAsOptional>true</flink.markBundledAsOptional>
Review Comment:
that was the plan
the only thing stopped me from making it here is that I was thinking about
making ShadeOptionalChecker working which then could be backported to 18.x and
then as a separate task sync maven-shade-plugin for all the modules
Or do you think it worth making it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
