rmannibucau commented on code in PR #1599:
URL:
https://github.com/apache/maven-dependency-plugin/pull/1599#discussion_r3030218852
##########
src/main/java/org/apache/maven/plugins/dependency/pom/DependencyCoordinates.java:
##########
@@ -25,14 +25,19 @@
/**
* Represents parsed Maven dependency coordinates (GAV +
scope/type/classifier).
* Supports parsing from a colon-separated string in the format:
- * {@code groupId:artifactId[:version[:scope[:type[:classifier]]]]}.
+ * {@code groupId:artifactId[:version]} or
+ * {@code groupId:artifactId[:extension[:classifier]]:version}.
+ *
+ * <p>This follows the standard Maven coordinate convention used by
+ * {@code org.eclipse.aether.artifact.DefaultArtifact}. Scope and optional
+ * are not part of coordinates and must be specified as separate
parameters.</p>
*
* @since 3.11.0
*/
public class DependencyCoordinates {
private static final Set<String> VALID_SCOPES =
- new HashSet<>(Arrays.asList("compile", "provided", "runtime",
"test", "system", "import"));
+ new HashSet<>(Arrays.asList("compile", "provided", "runtime",
"test", "system", "import", "test-runtime"));
Review Comment:
v3 is used with maven 4 so not sure this strategy is that relevant in
practise
the v4 branch is to migrate to v4 api, not for maven 4 compatibility
strictly speaking
that said some reflection can make it since dependency scope enum is
available on v4 and quite easy to make it match IMHO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
