brunoborges commented on PR #1599: URL: https://github.com/apache/maven-dependency-plugin/pull/1599#issuecomment-4184190077
## Update: Two major changes pushed ### 1. PomEditor rewritten with DomTrip (`faedbd1d`) Replaced ~450 lines of hand-rolled JAXP/DOM/Transformer code with [DomTrip](https://github.com/maveniverse/domtrip) (`eu.maveniverse.maven.domtrip:domtrip-maven:1.0.0`). PomEditor went from 697 → 343 lines (51% reduction). DomTrip handles all formatting preservation automatically — BOM, encoding, indentation, line endings, namespaces, and comments. Removed all manual workarounds (standalone="no" cleanup, BOM re-injection, indent detection via GCD, etc.). Kept a pre-parse DOCTYPE rejection check for XXE security. ### 2. Search goal removed (`13152c51`) Dropped `dependency:search` entirely (1,032 lines removed). The PR now focuses exclusively on `dependency:add` and `dependency:remove`. --- ### Remaining open questions for @rmannibucau From the original review feedback, these design decisions still need your input: 1. **GAV vs split parameters** — Keep both (`-Dgav=g:a:v` and `-DgroupId=... -DartifactId=...`) or pick one only? 2. **`managed` as enum** — Change from boolean to `YES/NO/BOTH` to allow adding to both `<dependencies>` and `<dependencyManagement>` in one invocation? 3. **`gav` as list** — Support batch operations like `-Dgav=g1:a1:v1,g2:a2:v2`? 4. **`bom` flag** — Remove it and let users set `-Dtype=pom -Dscope=import -Dmanaged=true` explicitly? 5. **Rename `DependencyCoordinates`** — Since it holds scope/optional which are not coordinates. Suggestions: `DependencyDescriptor`? `DependencySpec`? 6. **Add version to `validate()`** — Should validation require version to be present? 7. **JSON output option** — You mentioned enabling JSON dump and file output for pipeline use. Should we add `-Dformat=json` or `-DoutputFile=...` for the add/remove goals? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
