rmannibucau commented on PR #1599: URL: https://github.com/apache/maven-dependency-plugin/pull/1599#issuecomment-4180835008
@gnodet was domtrip fixed to keep null/empty tags (both cases) and xsd declaration formatting? At some point I got bitten by these 2/3 cases but was in early stages. @brunoborges while domtrip can be discussed cause kind of part of maven community as Guillaume mentionned, your PomEditor has issues on the formatting and creates yet another way to rewrite the pom so from my window it is either plain string manipulation specific to the dependency case like IDE do or some investment in domtrip as initially mentionned on the list before the PR and in previous review cycle guess it can also be saner to drop search mojo from a pr with add/remove (add remove are mainly some internal decisions about what we want to provide nothing crazy and we can agree quickly I guess but search has this external service dependency which is generally not working outside central so defeats the goal of the mojo which should be able to use company specific repositories and resolver like features IMHO, ultimately, in current form it can better match sonatype plugin than a maven one to be consistent, that said we have the incremental inde feature which is a way to provide such a feature even if not disk friendly, this is why we should discuss to either go nexus 2/3, artifactory etc or nothing). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
