brunoborges commented on PR #1599: URL: https://github.com/apache/maven-dependency-plugin/pull/1599#issuecomment-4184686997
## Summary of all changes addressing @rmannibucau review All design questions from the review have been resolved. Here is the full list of commits: 1. **Address review feedback** (`a18c1c5c`) — 14 actionable items (GAV format aligned to Aether, fail on duplicate, model sync, NONE sentinel removed, BAOS for HTTP, PluginDescriptor for version, test assertion messages) 2. **Remove test-runtime scope** (`9903dbaa`) — Focus on Maven 3.x scopes 3. **Replace hand-rolled DOM with DomTrip** (`faedbd1d`) — PomEditor rewritten using DomTrip (697→343 lines) 4. **Remove dependency:search goal** (`13152c51`) — PR now focused on add and remove only 5. **Use -Dgav only** (`4ae00111`) — Removed split groupId/artifactId/version params 6. **Rename DependencyCoordinates → DependencyEntry** (`116a4562`) — Reflects that the class holds more than just coordinates 7. **Fix error messages** (`20433035`) — References -Dgav instead of removed -Dversion 8. **Remove -Dbom flag** (`9c304854`) — Users use explicit `-Dgav=g:a:pom:v -Dscope=import -Dmanaged` instead ### Design decisions made: - **GAV vs split params**: GAV-only (`-Dgav`) - **-Dmanaged**: Kept as boolean (two invocations for BOTH case) - **-Dbom**: Removed (not needed, explicit params suffice) - **Version in validate()**: Not added — version requirements are context-dependent (remove needs none, add infers from parent) - **JSON output**: Not applicable to mutation goals (add/remove) - **List support for gav**: No (single dependency per invocation) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
