brunoborges commented on code in PR #1599:
URL:
https://github.com/apache/maven-dependency-plugin/pull/1599#discussion_r3030351149
##########
src/main/java/org/apache/maven/plugins/dependency/pom/DependencyCoordinates.java:
##########
@@ -25,14 +25,19 @@
/**
* Represents parsed Maven dependency coordinates (GAV +
scope/type/classifier).
* Supports parsing from a colon-separated string in the format:
- * {@code groupId:artifactId[:version[:scope[:type[:classifier]]]]}.
+ * {@code groupId:artifactId[:version]} or
+ * {@code groupId:artifactId[:extension[:classifier]]:version}.
+ *
+ * <p>This follows the standard Maven coordinate convention used by
+ * {@code org.eclipse.aether.artifact.DefaultArtifact}. Scope and optional
+ * are not part of coordinates and must be specified as separate
parameters.</p>
*
* @since 3.11.0
*/
public class DependencyCoordinates {
private static final Set<String> VALID_SCOPES =
- new HashSet<>(Arrays.asList("compile", "provided", "runtime",
"test", "system", "import"));
+ new HashSet<>(Arrays.asList("compile", "provided", "runtime",
"test", "system", "import", "test-runtime"));
Review Comment:
I'd rather keep this one simple. I think supporting objective phases is good
enough. If a user wants to select a more specific dependency, they should
manually modify `pom.xml` after it is added.
Once we land these goals, we can look at additional enhancements for Maven
4. Majority of users (like... _majority_) are on Maven 3.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
