peterxcli commented on code in PR #10036:
URL: https://github.com/apache/ozone/pull/10036#discussion_r3031222382


##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java:
##########
@@ -1089,8 +1089,10 @@ public static List<List<String>> format(
     for (ServiceInfo info : omNodes) {
       // Printing only the OM's running
       if (info.getNodeType() == HddsProtos.NodeType.OM) {
-        String role = info.getOmRoleInfo().getNodeId().equals(leaderId)
-                      ? "LEADER" : "FOLLOWER";
+        String nodeId = info.getOmRoleInfo().getNodeId();
+        String role = nodeId.equals(leaderId) ? "LEADER" : "FOLLOWER";
+        String leaderReadiness = nodeId.equals(leaderId)
+            ? "LEADER_AND_READY" : "NOT_LEADER";

Review Comment:
   Correct me if I'm wrong, I remember there are some enum with string literal 
defintiton already?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to