adoroszlai commented on code in PR #10036:
URL: https://github.com/apache/ozone/pull/10036#discussion_r3031922345
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java:
##########
@@ -1089,8 +1091,11 @@ public static List<List<String>> format(
for (ServiceInfo info : omNodes) {
// Printing only the OM's running
if (info.getNodeType() == HddsProtos.NodeType.OM) {
- String role = info.getOmRoleInfo().getNodeId().equals(leaderId)
- ? "LEADER" : "FOLLOWER";
+ String nodeId = info.getOmRoleInfo().getNodeId();
+ String role = nodeId.equals(leaderId) ?
+ LEADER.name() : FOLLOWER.name();
+ String leaderReadiness = nodeId.equals(leaderId)
+ ? "LEADER_AND_READY" : "NOT_LEADER";
Review Comment:
`leaderReadiness` should reflect readiness, but currently
`LEADER_AND_NOT_READY` cannot appear in the UI in any case. If we can get
correct information about the leader's readiness, we should. Otherwise we
should remove the column, since it's redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
