Russole commented on code in PR #10036:
URL: https://github.com/apache/ozone/pull/10036#discussion_r3112356756
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java:
##########
@@ -1089,8 +1091,11 @@ public static List<List<String>> format(
for (ServiceInfo info : omNodes) {
// Printing only the OM's running
if (info.getNodeType() == HddsProtos.NodeType.OM) {
- String role = info.getOmRoleInfo().getNodeId().equals(leaderId)
- ? "LEADER" : "FOLLOWER";
+ String nodeId = info.getOmRoleInfo().getNodeId();
+ String role = nodeId.equals(leaderId) ?
+ LEADER.name() : FOLLOWER.name();
+ String leaderReadiness = nodeId.equals(leaderId)
+ ? "LEADER_AND_READY" : "NOT_LEADER";
Review Comment:
Sounds good to me. I’ll update it so that on a follower OM, the leader row
is shown as LEADER and non-leader rows are shown as FOLLOWER or LISTENER; and
on a leader OM, the local leader row shows LEADER_AND_READY or
LEADER_AND_NOT_READY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
