Russole commented on code in PR #10036:
URL: https://github.com/apache/ozone/pull/10036#discussion_r3032004295


##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java:
##########
@@ -1089,8 +1091,11 @@ public static List<List<String>> format(
     for (ServiceInfo info : omNodes) {
       // Printing only the OM's running
       if (info.getNodeType() == HddsProtos.NodeType.OM) {
-        String role = info.getOmRoleInfo().getNodeId().equals(leaderId)
-                      ? "LEADER" : "FOLLOWER";
+        String nodeId = info.getOmRoleInfo().getNodeId();
+        String role = nodeId.equals(leaderId) ?
+            LEADER.name() : FOLLOWER.name();
+        String leaderReadiness = nodeId.equals(leaderId)
+            ? "LEADER_AND_READY" : "NOT_LEADER";

Review Comment:
   Thanks @adoroszlai for the review — good catch.
   Currently, the UI does not have access to the actual leader readiness for 
each OM, so the value is derived from the node’s role. As a result, 
LEADER_AND_NOT_READY cannot be reflected.
   
   We can either extend this to fetch the real leader readiness from the leader 
node, or consider removing the column if it is considered redundant.
   
   This change focuses on fixing the inconsistent UI behavior across leader and 
follower nodes while keeping the existing semantics unchanged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to