Russole commented on code in PR #10036:
URL: https://github.com/apache/ozone/pull/10036#discussion_r3031714616
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java:
##########
@@ -1089,8 +1089,10 @@ public static List<List<String>> format(
for (ServiceInfo info : omNodes) {
// Printing only the OM's running
if (info.getNodeType() == HddsProtos.NodeType.OM) {
- String role = info.getOmRoleInfo().getNodeId().equals(leaderId)
- ? "LEADER" : "FOLLOWER";
+ String nodeId = info.getOmRoleInfo().getNodeId();
+ String role = nodeId.equals(leaderId) ? "LEADER" : "FOLLOWER";
+ String leaderReadiness = nodeId.equals(leaderId)
+ ? "LEADER_AND_READY" : "NOT_LEADER";
Review Comment:
Good point. `RaftServerStatus` defines these values, but it is in the
`ozone-manager` module and cannot be used here due to module boundaries.
For LEADER and FOLLOWER, I used the existing `RaftPeerRole` enum instead of
string literals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
