Russole commented on code in PR #10036:
URL: https://github.com/apache/ozone/pull/10036#discussion_r3035020903


##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java:
##########
@@ -1089,8 +1091,11 @@ public static List<List<String>> format(
     for (ServiceInfo info : omNodes) {
       // Printing only the OM's running
       if (info.getNodeType() == HddsProtos.NodeType.OM) {
-        String role = info.getOmRoleInfo().getNodeId().equals(leaderId)
-                      ? "LEADER" : "FOLLOWER";
+        String nodeId = info.getOmRoleInfo().getNodeId();
+        String role = nodeId.equals(leaderId) ?
+            LEADER.name() : FOLLOWER.name();
+        String leaderReadiness = nodeId.equals(leaderId)
+            ? "LEADER_AND_READY" : "NOT_LEADER";

Review Comment:
   Thanks @adoroszlai , based on the current implementation of 
`OzoneManagerRatisServer`, `getLeaderStatus()` only reflects the local OM's 
Raft server state (via the local division), and there is no mechanism to 
retrieve readiness for other OM nodes.
   
   This means the UI currently does not have access to per-node leader 
readiness in an HA setup.
   
   So while the original issue comes from applying the local status to all 
rows, the underlying limitation is that per-OM readiness is not available from 
the current API.
   
   Given that, we may need to either extend the backend to expose per-node 
readiness, or consider removing the column if that information cannot be 
accurately represented.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to