tkhurana commented on code in PR #2134:
URL: https://github.com/apache/phoenix/pull/2134#discussion_r2069096191
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java:
##########
@@ -611,6 +612,29 @@ private boolean areMutationsInSameTable(Table
targetHTable, Region region) {
region.getTableDescriptor().getTableName().getName()) == 0);
}
+ @Override
+ public InternalScanner
preFlush(ObserverContext<RegionCoprocessorEnvironment> c, Store store,
+ InternalScanner scanner,
FlushLifeCycleTracker tracker)
+ throws IOException {
+ if (!isPhoenixTableTTLEnabled(c.getEnvironment().getConfiguration())) {
Review Comment:
Yeah I think it will be better because Phoenix compaction has already been
running in production and this is a new feature so having this flexibility will
be helpful. We can enable it by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
