virajjasani commented on code in PR #2134:
URL: https://github.com/apache/phoenix/pull/2134#discussion_r2074782800
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java:
##########
@@ -611,6 +612,29 @@ private boolean areMutationsInSameTable(Table
targetHTable, Region region) {
region.getTableDescriptor().getTableName().getName()) == 0);
}
+ @Override
+ public InternalScanner
preFlush(ObserverContext<RegionCoprocessorEnvironment> c, Store store,
+ InternalScanner scanner,
FlushLifeCycleTracker tracker)
+ throws IOException {
+ if (!isPhoenixTableTTLEnabled(c.getEnvironment().getConfiguration())) {
Review Comment:
This flexibility will be helpful. I think we can go ahead with merging the
changes after config is added and perf can be done later. The config will
anyways be helpful to turn off the feature, WDYT @tkhurana?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
