sanjeet006py commented on code in PR #2134:
URL: https://github.com/apache/phoenix/pull/2134#discussion_r2077073311
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java:
##########
@@ -611,6 +612,29 @@ private boolean areMutationsInSameTable(Table
targetHTable, Region region) {
region.getTableDescriptor().getTableName().getName()) == 0);
}
+ @Override
+ public InternalScanner
preFlush(ObserverContext<RegionCoprocessorEnvironment> c, Store store,
+ InternalScanner scanner,
FlushLifeCycleTracker tracker)
+ throws IOException {
+ if (!isPhoenixTableTTLEnabled(c.getEnvironment().getConfiguration())) {
Review Comment:
@virajjasani perf analysis for multi-CF will take some time as I got to know
that HBase flushTime metrics for multi-CF case sometimes could end up tracking
combined time for flushing multiple CFs and other times only 1 CF. So, need to
directly track time taken by StoreFlusher.
One idea is we wait for perf analysis before merging this PR but 5.3 release
can go on or if we want this PR in 5.3 then for now we can disable preFlush
hook via config and only enable it after perf analysis. I am bit inclined
towards first approach. WDYT @virajjasani @tkhurana?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
