[ 
https://issues.apache.org/jira/browse/SOLR-15321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432634#comment-17432634
 ] 

Chris M. Hostetter commented on SOLR-15321:
-------------------------------------------

I am happy to defer to houston on all of this, because i'm sure he's thought 
about it more then me, but two things i wanted to note...

1) ...
{quote}Then in the release wizard, have a step at the end that clones that 
repo, adds the resulting official docker image from the RC and commits it.
{quote}
There's two important steps after that that the release wizard/process will 
need to handle:
 * we need scripts (similar to what are already in the 
github/docker-solr/docker-solr repo) to generate an updated 
[library/solr|https://github.com/docker-library/official-images/blob/master/library/solr]
 "manifest" file listing all the solr releases
 * submiting the PR to github/docker-library/official-images with the updated 
manifest file

2) ...
{quote}... and import all of the old builds that we want to still be updated 
(probably just the 8x ones).
{quote}
...I don't think we even have to do that.  We just need the manifest file 
generated by our apache/solr-docker repo to still include the list of those old 
builds and point to github/docker-solr/docker-solr for them (the {{GitRepo}} 
option can be overridden per release)

So we can keep the new apache/solr-docker repo "clean" (just simple Dockerfiles 
for 9.0 and forward) while still listing the older builds ... what would also 
need to change though is the existing scripts/process on the 
github/docker-solr/docker-solr side for what to do if/when 8.x (or older) bug 
fix releases happen ... those scripts/docs can't assume they "own" the entire 
library/solr manifest file, they would need to just generate a "snippet" of the 
manifest file listing the pre-9.0 build which we would then commit somewhere to 
apache/solr-docker which could be slurped up when generating the final list in 
cluding 9.0+ releases

Even if we decide it's better to completely import the scripts & older release 
directories from github/docker-solr/docker-solr into apache/solr-docker the 
docs & scripts will need a lot of work to understand how to treat pre-9.0 
builds differently from 9.0 and on builds. I suspect it will be easier to leave 
all that pre-9.0 stuff in the old repo and just revise those older docs and 
older generate-stackbrew-library.sh script (to put a GitRepo entry on every 
entry) about submitting the final output as a PR to apache/solr-docker instead 
of directly to docker-library/official-images

> Flesh out process for managing/storing "official" Dockerfiles used by 
> docker-library
> ------------------------------------------------------------------------------------
>
>                 Key: SOLR-15321
>                 URL: https://issues.apache.org/jira/browse/SOLR-15321
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Chris M. Hostetter
>            Assignee: Houston Putman
>            Priority: Blocker
>             Fix For: main (9.0)
>
>
> Assuming we (the Apache Solr TLP) do want to be the maintainer of "official" 
> {{_/solr}} docker images moving forward, we need to flesh out how/where 
> exactly we plan on storing/managing/maintaining the Dockerfiles that should 
> be pointed to by the docker-library manifest file for solr...
> [https://github.com/docker-library/official-images/blob/master/library/solr]
> ie:
>  * what replaces [https://github.com/docker-solr/docker-solr.git]
>  * what process do we use to update/manage this?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to