[ 
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656186#comment-17656186
 ] 

Ishan Chattopadhyaya edited comment on SOLR-16531 at 1/9/23 4:54 PM:
---------------------------------------------------------------------

>From the comments above and based on concerns from Noble, my suggestion is 
>that we revert all the changes now and start afresh once we've discussed every 
>tradeoff and aspect of the new approach (resteasy or per configset app or any 
>other approach) in detail (possibly via SIP). It is a distinct possibility 
>that there are regressions that have crept in recently, but no benchmarking is 
>meaningful on that branch for the kinds of tests we're currently doing because 
>of the JAX RS degradation.


was (Author: ichattopadhyaya):
>From the comments above and based on concerns from Noble, my suggestion is 
>that we revert all the changes now and start afresh once we've discussed every 
>tradeoff and aspect of the new approach (resteasy or per configset app or any 
>other approach) in detail (possibly via SIP). It is a distinct possibility 
>that there are regressions that have crept in recently, but no benchmarking is 
>meaningless on that branch for the kinds of tests we're currently doing 
>because of JAX RS.

> Performance degradation due to introduction of JAX-RS
> -----------------------------------------------------
>
>                 Key: SOLR-16531
>                 URL: https://issues.apache.org/jira/browse/SOLR-16531
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Ishan Chattopadhyaya
>            Priority: Blocker
>             Fix For: 9.2
>
>         Attachments: Screenshot from 2022-11-09 11-20-44.png, 
> jaxrs-integration-with-app-per-configset-flamegraph.html, 
> results-with-patch.tar.gz, vanilla-jaxrs-integration-flamegraph.html
>
>
> During performance benchmarking on branch_9x, I observed a slowdown in 
> restart performance since commits in SOLR-16347. See attached screenshot.
> CC [~gerlowskija].
> http://mostly.cool/cluster-test-with-patch.html
> The benchmark is here: 
> https://github.com/fullstorydev/solr-bench/blob/ishan/repeatable-jenkins/suites/cluster-test.json.
>  This suite was run after retro-actively applying the parallelStream patch 
> from SOLR-16414: 
> https://github.com/apache/solr/commit/b33161d0cdd976fc0c3dc78c4afafceb4db671cf.diff
>  
> Effort to automate these benchmarks is WIP and tracked here: SOLR-16525.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to