[
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17657007#comment-17657007
]
Noble Paul edited comment on SOLR-16531 at 1/10/23 11:16 PM:
-------------------------------------------------------------
I think we are pretty close to a working solution and I'm extremely confident
that we will be able to make this to 9.2. Also, I agree with Ishan that the
path forward is to revert everything from branch_9x and get the branch into a
clean state and commit all the changes in one go (along with the per configset
jersey app).
This will give all of us enough time to review and iterate this solution
properly. I can volunteer to do any help required (review, perf test, revert
and create the necessary branches)
As Ishan mentioned, there is no need take any unnecessary stress. We just need
to set the right precedent on the process we need to follow when there is a
regression. We are not working against each other, we are in this together.
thanks again to [~gerlowskija] for coming up with a solution for the perf
regression during the holidays (and weekends).
was (Author: noble.paul):
I think we are pretty close to a working solution and I'm extremely confident
that we will be able to make this to 9.2. Also, I agree with Ishan that the
path forward is to revert everything from branch_9x and get the branch into a
clean state and commit all the changes in one go (along with the per configset
jersey app).
This will give all of us enough time to review and iterate this solution
properly. I can volunteer to do any help required (review, perf test, revert
and create the necessary branches)
thanks again to [~gerlowskija] for coming up with a solution for the perf
regression during the holidays (and weekends).
> Performance degradation due to introduction of JAX-RS
> -----------------------------------------------------
>
> Key: SOLR-16531
> URL: https://issues.apache.org/jira/browse/SOLR-16531
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Ishan Chattopadhyaya
> Priority: Blocker
> Fix For: 9.2
>
> Attachments: Screenshot from 2022-11-09 11-20-44.png,
> jaxrs-integration-with-app-per-configset-flamegraph.html,
> results-with-patch.tar.gz, vanilla-jaxrs-integration-flamegraph.html
>
>
> During performance benchmarking on branch_9x, I observed a slowdown in
> restart performance since commits in SOLR-16347. See attached screenshot.
> CC [~gerlowskija].
> http://mostly.cool/cluster-test-with-patch.html
> The benchmark is here:
> https://github.com/fullstorydev/solr-bench/blob/ishan/repeatable-jenkins/suites/cluster-test.json.
> This suite was run after retro-actively applying the parallelStream patch
> from SOLR-16414:
> https://github.com/apache/solr/commit/b33161d0cdd976fc0c3dc78c4afafceb4db671cf.diff
>
> Effort to automate these benchmarks is WIP and tracked here: SOLR-16525.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
