[
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675757#comment-17675757
]
Ishan Chattopadhyaya edited comment on SOLR-16531 at 1/12/23 12:48 AM:
-----------------------------------------------------------------------
bq. the amount of time a node spends restarting vs it's total life-time, is
negligible. ~25% of that negligible time shouldn't be a blocker for us to make
progress here. To be clear, we should continue to improve this however I don't
see it as a blocker.
Just to be clear, I'm withrawing my veto so that immediate revert isn't
necessary. However, this continues to be a release blocker, and arguments that
a 30% startup slowdown is acceptable are deeply condemnable.
was (Author: ichattopadhyaya):
bq. the amount of time a node spends restarting vs it's total life-time, is
negligible. ~25% of that negligible time shouldn't be a blocker for us to make
progress here. To be clear, we should continue to improve this however I don't
see it as a blocker.
Just to be clear, I'm withrawing my veto so that immediate revert isn't
necessary. However, this continues to be a release blocker, and arguments that
a 30% startup slowdown is negligible are deeply condemnable.
> Performance degradation due to introduction of JAX-RS
> -----------------------------------------------------
>
> Key: SOLR-16531
> URL: https://issues.apache.org/jira/browse/SOLR-16531
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Ishan Chattopadhyaya
> Priority: Blocker
> Fix For: 9.2
>
> Attachments: Screenshot from 2022-11-09 11-20-44.png,
> jaxrs-integration-with-app-per-configset-flamegraph.html,
> results-with-patch.tar.gz, vanilla-jaxrs-integration-flamegraph.html
>
>
> During performance benchmarking on branch_9x, I observed a slowdown in
> restart performance since commits in SOLR-16347. See attached screenshot.
> CC [~gerlowskija].
> http://mostly.cool/cluster-test-with-patch.html
> The benchmark is here:
> https://github.com/fullstorydev/solr-bench/blob/ishan/repeatable-jenkins/suites/cluster-test.json.
> This suite was run after retro-actively applying the parallelStream patch
> from SOLR-16414:
> https://github.com/apache/solr/commit/b33161d0cdd976fc0c3dc78c4afafceb4db671cf.diff
>
> Effort to automate these benchmarks is WIP and tracked here: SOLR-16525.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
