[ 
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654184#comment-17654184
 ] 

Jason Gerlowski edited comment on SOLR-16531 at 1/3/23 8:34 PM:
----------------------------------------------------------------

bq. Looks like this could be an issue with hardware? Can you please post the 
specs of the machine where this was running?

I'm not sure what to chalk it up to beyond hardware.  But my test machine is 
pretty beefy; it seems like it should be able to handle things, but who knows?  
I'm using a Mac Pro with a 14-core "Intel Xeon" processor, 128gb of RAM, and a 
SSD for disk.  What have you been using for your testing?

bq. Please let me know if you have a branch with the improvements ready that 
you want me to test (solr-bench) on the same hardware where I've been running 
the tests till now

Yeah, that'd be great, thanks!  The branch 
[here|https://github.com/gerlowskija/solr/tree/jaxrs-with-partial-fix] rewinds 
to the introduction of JAX-RS on main (8efed0) and adds a single commit 
(8d6052) that partially alleviates the perf regression.  (If you'd prefer 
something based on the latest {{main}} or {{branch_9x}} etc, that single commit 
should be pretty cherry-pick-able, or I'd be happy to make a branch with a 
different base if you lmk.)


was (Author: gerlowskija):
bq. Looks like this could be an issue with hardware? Can you please post the 
specs of the machine where this was running?

I'm not sure what to chalk it up to beyond hardware.  But my test machine is 
pretty beefy; it seems like it should be able to handle things, so who knows?  
I'm using a Mac Pro with a 14-core "Intel Xeon" processor, 128gb of RAM, and a 
SSD for disk.  What have you been using for your testing?

bq. Please let me know if you have a branch with the improvements ready that 
you want me to test (solr-bench) on the same hardware where I've been running 
the tests till now

Yeah, that'd be great, thanks!  The branch 
[here|https://github.com/gerlowskija/solr/tree/jaxrs-with-partial-fix] rewinds 
to the introduction of JAX-RS on main (8efed0) and adds a single commit 
(8d6052) that partially alleviates the perf regression.  (If you'd prefer 
something based on the latest {{main}} or {{branch_9x}} etc, that single commit 
should be pretty cherry-pick-able, or I'd be happy to make a branch with a 
different base if you lmk.)

> Performance degradation due to introduction of JAX-RS
> -----------------------------------------------------
>
>                 Key: SOLR-16531
>                 URL: https://issues.apache.org/jira/browse/SOLR-16531
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Ishan Chattopadhyaya
>            Priority: Blocker
>             Fix For: 9.2
>
>         Attachments: Screenshot from 2022-11-09 11-20-44.png, 
> results-with-patch.tar.gz
>
>
> During performance benchmarking on branch_9x, I observed a slowdown in 
> restart performance since commits in SOLR-16347. See attached screenshot.
> CC [~gerlowskija].
> http://mostly.cool/cluster-test-with-patch.html
> The benchmark is here: 
> https://github.com/fullstorydev/solr-bench/blob/ishan/repeatable-jenkins/suites/cluster-test.json.
>  This suite was run after retro-actively applying the parallelStream patch 
> from SOLR-16414: 
> https://github.com/apache/solr/commit/b33161d0cdd976fc0c3dc78c4afafceb4db671cf.diff
>  
> Effort to automate these benchmarks is WIP and tracked here: SOLR-16525.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to