abstractdog commented on code in PR #326:
URL: https://github.com/apache/tez/pull/326#discussion_r1894644719
##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/InputAttemptIdentifier.java:
##########
@@ -108,6 +108,10 @@ public boolean canRetrieveInputInChunks() {
(fetchTypeInfo == SPILL_INFO.FINAL_UPDATE.ordinal());
}
+ public boolean include(int thatInputIdentifier, int thatAttemptNumber) {
Review Comment:
this method would be simpler with a single param:
```
includes(InputAttempIdentifier inputAttemptIdentifier)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
