ngsg commented on code in PR #326:
URL: https://github.com/apache/tez/pull/326#discussion_r1895460076
##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/impl/ShuffleManager.java:
##########
@@ -583,8 +583,15 @@ Fetcher constructFetcherForHost(InputHost inputHost,
Configuration conf) {
} else {
alreadyCompleted = completedInputSet.get(input.getInputIdentifier());
}
- // Avoid adding attempts which have already completed or have been
marked as OBSOLETE
- if (alreadyCompleted || obsoletedInputs.contains(input)) {
+
+ // Avoid adding attempts which have already completed
+ if (alreadyCompleted) {
+ inputIter.remove();
+ continue;
+ }
+ // Avoid adding attempts which have been marked as OBSOLETE
+ if (isObsoleteInputAttemptIdentifier(input)) {
+ LOG.info("Skipping obsolete input: " + input);
Review Comment:
I think it would be better to synchronize the behaviour of `ShuffleManager`
and `ShuffleScheduler`. Modified to use a single if clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
