abstractdog commented on code in PR #326:
URL: https://github.com/apache/tez/pull/326#discussion_r1894644288
##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/CompositeInputAttemptIdentifier.java:
##########
@@ -50,6 +50,12 @@ public InputAttemptIdentifier expand(int
inputIdentifierOffset) {
return new InputAttemptIdentifier(getInputIdentifier() +
inputIdentifierOffset, getAttemptNumber(), getPathComponent(), isShared(),
getFetchTypeInfo(), getSpillEventId());
}
+ public boolean include(int thatInputIdentifier, int thatAttemptNumber) {
Review Comment:
few notes:
1. nit: this is more like "includes" because the method answers a question
like whether this composite identifier includes another one, rather than taking
and action
2. this method would be simpler with a single param:
```
includes(InputAttempIdentifier inputAttemptIdentifier)
```
3. can you please add a method javadoc about what "includes" exactly means
in this context
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
