abstractdog commented on code in PR #326:
URL: https://github.com/apache/tez/pull/326#discussion_r1894645785
##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/CompositeInputAttemptIdentifier.java:
##########
@@ -50,6 +50,12 @@ public InputAttemptIdentifier expand(int
inputIdentifierOffset) {
return new InputAttemptIdentifier(getInputIdentifier() +
inputIdentifierOffset, getAttemptNumber(), getPathComponent(), isShared(),
getFetchTypeInfo(), getSpillEventId());
}
+ public boolean include(int thatInputIdentifier, int thatAttemptNumber) {
+ return
+ super.getInputIdentifier() <= thatInputIdentifier &&
thatInputIdentifier < (super.getInputIdentifier() + inputIdentifierCount) &&
Review Comment:
can you reuse e.g. guava's Range for better readability?
https://www.geeksforgeeks.org/range-class-guava-java/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
