ngsg commented on code in PR #326:
URL: https://github.com/apache/tez/pull/326#discussion_r1895428206
##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/shuffle/impl/ShuffleManager.java:
##########
@@ -949,10 +956,14 @@ public void fetchFailed(String host,
// TODO NEWTEZ. Implement logic to report fetch failures after a threshold.
// For now, reporting immediately.
InputAttemptIdentifier srcAttemptIdentifier =
inputAttemptFetchFailure.getInputAttemptIdentifier();
+ if (isObsoleteInputAttemptIdentifier(srcAttemptIdentifier)) {
+ LOG.info("Do not report obsolete input: " + srcAttemptIdentifier);
+ return;
+ }
LOG.info(
- "{}: Fetch failed for src: {} InputIdentifier: {}, connectFailed: {}, "
+ "{}: Fetch failed for InputIdentifier: {}, connectFailed: {}, "
+ "local fetch: {}, remote fetch failure reported as local
failure: {})",
- sourceDestNameTrimmed, srcAttemptIdentifier, srcAttemptIdentifier,
connectFailed,
+ sourceDestNameTrimmed, srcAttemptIdentifier, connectFailed,
Review Comment:
Yes, it is intended change. Both `src: {}` and `InputIdentifier: {}` print
`srcAttemptIdentifier`, so I removed `src: {}`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
