ngsg commented on code in PR #326:
URL: https://github.com/apache/tez/pull/326#discussion_r1895474210
##########
tez-runtime-library/src/main/java/org/apache/tez/runtime/library/common/CompositeInputAttemptIdentifier.java:
##########
@@ -50,6 +50,12 @@ public InputAttemptIdentifier expand(int
inputIdentifierOffset) {
return new InputAttemptIdentifier(getInputIdentifier() +
inputIdentifierOffset, getAttemptNumber(), getPathComponent(), isShared(),
getFetchTypeInfo(), getSpillEventId());
}
+ public boolean include(int thatInputIdentifier, int thatAttemptNumber) {
Review Comment:
I agree that `includes` is more appropriate for the method. I modified the
signature of the method as well as its name, and attached a javadoc on top of
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
