> > Did your fix create the test-breakage?  If so, is the test wrong, or
> > did we introduce a new bug?
> > If the test itself is wrong, go ahead and commit.  If your fix for one
> > bug created another, then let's discuss first, on the list.
> 
> As far as I can tell, my bug-fix shows the test to be wrong.. which is
> quite funny if you think about it. Where did you get the "correct"
> values from ?

Mostly just our (possibly erroneous) thinking about what should result. ;)
We've had several test cases over the months which were Just Plain Wrong. 

> I subclassed the XPathTestBase class with another class, which compares
> the count from Jaxen to the count returned by Xalan instead of comparing
> it to the "correct" count in the test file. (Xalan may be slow, but for
> as far as I have used it, it has always returned the correct results)

Cool.  Xalan is part of our lib/ directory, I think, so go ahead and
add your comparison test driver permanently, if you like.

> A bit of after-work hacking going on here.. hope I'll be able to commit
> all this bug-free tomorrow.

Great!

        -bob


_______________________________________________
Jaxen-interest mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/jaxen-interest

Reply via email to