dajac commented on code in PR #12748:
URL: https://github.com/apache/kafka/pull/12748#discussion_r1031512818


##########
clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java:
##########
@@ -44,14 +46,26 @@ public AbstractStickyAssignor createAssignor() {
     }
 
     @Override
-    public Subscription buildSubscription(List<String> topics, 
List<TopicPartition> partitions) {
-        return new Subscription(topics, assignor.subscriptionUserData(new 
HashSet<>(topics)), partitions);
+    public Subscription buildSubscriptionV0(List<String> topics, 
List<TopicPartition> partitions, int generationId) {
+        // cooperative sticky assignor only supports 
ConsumerProtocolSubscription V1 or above
+        return null;

Review Comment:
   nit: If it should not be used, would it make sense to throw an exception? 
e.g. IllegalStateException



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to