urbandan commented on code in PR #13458:
URL: https://github.com/apache/kafka/pull/13458#discussion_r1153232337
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java:
##########
@@ -223,6 +231,15 @@ ForwardingAdmin forwardingAdmin(Map<String, Object>
config) {
}
}
+ void addClientId(Map<String, Object> props, String role) {
+ String clientId = entityLabel() + (role == null ? "" : "|" + role);
+ props.put(CommonClientConfigs.CLIENT_ID_CONFIG, clientId);
Review Comment:
good point, will do - one note though: since current the control over the
client.ids of different nested clients is very limited, I'm not sure if it is
actually useful, e.g. in MM2 dedicated mode, the most specific config users can
use is something like source.consumer.client.id, but that doesn't differentiate
between MirrorSourceTask replication consumers or MirrorCheckpointTask offset
sync consumers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
