urbandan commented on code in PR #13458:
URL: https://github.com/apache/kafka/pull/13458#discussion_r1153234005
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorHeartbeatConnector.java:
##########
@@ -48,8 +48,8 @@ public MirrorHeartbeatConnector() {
@Override
public void start(Map<String, String> props) {
config = new MirrorHeartbeatConfig(props);
- targetAdminClient = config.forwardingAdmin(config.targetAdminConfig());
- scheduler = new Scheduler(MirrorHeartbeatConnector.class,
config.adminTimeout());
+ targetAdminClient =
config.forwardingAdmin(config.targetAdminConfig("target-admin"));
Review Comment:
this will be prefixed with the Connector name, with that in mind, it seemed
redundant to me, but I can be more specific
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
