urbandan commented on code in PR #13458:
URL: https://github.com/apache/kafka/pull/13458#discussion_r1154222170
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java:
##########
@@ -200,6 +200,8 @@ public Map<String, String> workerConfig(SourceAndTarget
sourceAndTarget) {
// fill in reasonable defaults
props.putIfAbsent(GROUP_ID_CONFIG, sourceAndTarget.source() + "-mm2");
+ String groupId = props.get(GROUP_ID_CONFIG);
+ props.putIfAbsent(CommonClientConfigs.CLIENT_ID_CONFIG, groupId + "|"
+ sourceAndTarget);
Review Comment:
Thanks for the clarification - not going to add the group ID here, but I
will still try to set it based on the flow.
In MM2, the group ID only contains the source alias, with specific setups
(e.g. star architecture) the group ID is not unique in a single process.
DistributedHerder logs do contain the client ID, and I found it useful in many
situations (e.g. tracking rebalances/assignments of a specific flow).
Thanks for the hint about the shared admin, will fix that, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
