urbandan commented on code in PR #13458:
URL: https://github.com/apache/kafka/pull/13458#discussion_r1153239111
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java:
##########
@@ -199,6 +199,7 @@ public Map<String, String> workerConfig(SourceAndTarget
sourceAndTarget) {
props.putAll(stringsWithPrefix(CONFIG_PROVIDERS_CONFIG));
// fill in reasonable defaults
+ props.putIfAbsent(CommonClientConfigs.CLIENT_ID_CONFIG,
sourceAndTarget.toString());
Review Comment:
Will remove the change from MirrorMaker, then this will start to make sense,
thanks for catching this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
