urbandan commented on code in PR #13458:
URL: https://github.com/apache/kafka/pull/13458#discussion_r1153244635
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##########
@@ -291,6 +291,7 @@ public DistributedHerder(DistributedConfig config,
String clientIdConfig =
config.getString(CommonClientConfigs.CLIENT_ID_CONFIG);
String clientId = clientIdConfig.length() <= 0 ? "connect-" +
CONNECT_CLIENT_ID_SEQUENCE.getAndIncrement() : clientIdConfig;
+ String escapedClientId = clientId.replace("%", "%%");
Review Comment:
This was caught by one of the MM2 tests using a cluster alias with a %
inside. That caused the thread factory naming pattern to crash, as
String.format thinks % represents some placeholder. Will add a comment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
