urbandan commented on code in PR #13458:
URL: https://github.com/apache/kafka/pull/13458#discussion_r1153243008
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##########
@@ -71,9 +72,9 @@ public void start(Map<String, String> props) {
String connectorName = config.connectorName();
sourceAndTarget = new SourceAndTarget(config.sourceClusterAlias(),
config.targetClusterAlias());
groupFilter = config.groupFilter();
- sourceAdminClient = config.forwardingAdmin(config.sourceAdminConfig());
- targetAdminClient = config.forwardingAdmin(config.targetAdminConfig());
- scheduler = new Scheduler(MirrorCheckpointConnector.class,
config.adminTimeout());
+ sourceAdminClient =
config.forwardingAdmin(config.sourceAdminConfig("source-admin"));
+ targetAdminClient =
config.forwardingAdmin(config.targetAdminConfig("target-admin"));
+ scheduler = new Scheduler(config.entityLabel(), config.adminTimeout());
Review Comment:
I think this makes sense in both Connect and MM2 dedicated mode. The
available log context in Connect only tracks the Connector name + Task ID (+
scope), I was following that logic.
Again, can be more specific, and can prefix all of this with the
Connector/Task class, but seems redundant to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
