mumrah commented on a change in pull request #11677: URL: https://github.com/apache/kafka/pull/11677#discussion_r784226775
########## File path: metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java ########## @@ -251,7 +267,7 @@ public void deactivate() { List<ApiMessageAndVersion> records = new ArrayList<>(); records.add(new ApiMessageAndVersion(record, - REGISTER_BROKER_RECORD.highestSupportedVersion())); + metadataVersionProvider.activeVersion().recordVersion(REGISTER_BROKER_RECORD))); Review comment: Assuming we are fine with this usage pattern, we will need to make this change any time we serialize a record -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org