cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784426548
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/FeatureUpdate.java
##########
@@ -24,6 +24,24 @@
public class FeatureUpdate {
private final short maxVersionLevel;
private final boolean allowDowngrade;
+ private final DowngradeType downgradeType;
+
+ public enum DowngradeType {
+ UNSET(-1), // Used for backwards compatibility with allowDowngrade
Review comment:
We shouldn't need a fourth enum value, right? The KIP just says that
passing `allowDowngrade = true` to the old constructor is equivalent to setting
`DowngradeType.SAFE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
