ngraham added a comment.
I just realized that we have another case in `KWidgetsAddons` that could benefit from your read-theme-colors-without-using-kconfig idea: D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays <https://phabricator.kde.org/D12756> Would you mind putting it into a function and submitting it in another patch? I think it could be nice to have available more generally. INLINE COMMENTS > ngraham wrote in kmessagewidget.cpp:311 > I don't think all of this complicated code is necessary. The theme itself is > supposed to ensure readability with the colors that it uses. Also, this > results in a slight regression for the Breeze Dark theme: the Information > widget doesn't get enough alpha and is too bright, worsening readability > compared to the status quo. Also, commits should be atomic; even if we want to do this, it should be in another patch since it represents a separate conceptual change compared to the status quo, as opposed to simply a bugfix or missing feature. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13777 To: rjvbb, ngraham, #frameworks Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns
