rjvbb updated this revision to Diff 36858. rjvbb added a comment.
The need for an extra check in `qColorFromSettings()` meant I changed the API to put all tests in there and added a default return value argument. IOW, basically the same API as KConfig has. I've simplified the information alpha calculation, now looking only at the message background colour intensity. I think that should address the issue with dark themes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13777?vs=36846&id=36858 REVISION DETAIL https://phabricator.kde.org/D13777 AFFECTED FILES src/kmessagewidget.cpp To: rjvbb, ngraham, #frameworks Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns