On Fri, Jan 12, 2007 at 01:46:26AM +0000, Joseph Nahmias wrote:
> On Thu, Jan 11, 2007 at 02:28:49PM -0500, Bob Copeland wrote:
> > This patch misses the case where you just copy the files on the command
> > line [ if(optind < argc){ ... ]. It'd be even better to make the io_lock
> > paths symmetrical. I'll try to spin a patch for this tonight.
On second thought I'm not sure if we should change it. Yeah, it's weird
for the db to be rewritten on just a query, but on the other hand
"riocp -b" has been documented as being a quick Rescan Music trick (though
that's mostly just a happy side-effect).
> I applied the attached lk_karmaUsb_write_smalldb_perror.patch along with
> the two patches you posted in the other mail. It's now much better, see
> attached karma_debug_take2.log; but riocp still seems to be messing with
> smalldb in uncertain ways. See especially the file sizes before/after
> each query.
It's dropping one song off the end every time. Keith Bennett mentioned
an off-by-one that he found, but I didn't see a patch for it (nor do I
know where it is atm, but I haven't had a chance to look deeply).
FWIW to infer the above I used my smalldb dump utility at:
http://bobcopeland.com/karma/releases/karmadb-1.2.tar.gz
> I'm jello on irc.debian.org (OFTC) or irc.freenode.net. Just /msg jello
> and I should reply.
OK, didn't get around to it tonight but may in the future...
--
Bob Copeland %% www.bobcopeland.com
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-karma-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-karma-devel
