> I get segfault *without* uploading anything; just "./riocp" Can
> I take for sure that the current tip (changeset 130) contains all
> your patches?
Ah, I just checked and it's missing one of the two that I sent batched
in a single email. And yes, it will definitely cause a segfault. I
don't know how long this bug has been in there but it's a while: the
error handling path of read smalldb never cleared the dmap or playlist
count even though both are supposed to be freed.
Franky, please apply this one.
# HG changeset patch
# User [EMAIL PROTECTED]
# Date 1168559805 18000
# Node ID 9c805535e504cf8a379cdc028941499b011a7100
# Parent 0a2e507959e8ed0bb282e18f34631f145dafcd89
Blank out dmap and playlist counts
diff -r 0a2e507959e8 -r 9c805535e504 src/karmaUsb.c
--- a/src/karmaUsb.c Thu Jan 11 18:17:02 2007 -0500
+++ b/src/karmaUsb.c Thu Jan 11 18:56:45 2007 -0500
@@ -741,8 +741,6 @@ static int32_t read_properties_smalldb(c
}
*ptr = '\0';
*properties = tmp;
- db->dmap_size = 0;
- db->num_playlists = 0;
out:
ret = 0;
@@ -755,6 +753,8 @@ static int32_t read_properties_smalldb(c
free(prop_strs);
if (db)
{
+ db->dmap_size = 0;
+ db->num_playlists = 0;
if (db->dmap)
free(db->dmap);
if (db->playlists)
--
Bob Copeland %% www.bobcopeland.com
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-karma-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-karma-devel
