On Wed, Feb 25, 2015 at 4:07 PM, Georg Baum <georg.b...@post.rwth-aachen.de> wrote: > Scott Kostyshak wrote: > >> 0005-Check-exit-code-of-LaTeX-process-in-LaTeX-run.patch >> - To see why this patch is useful, open New > New from Template > >> ACM-sigplan.lyx and compile. It says that compilation was successful >> and shows the PDF. However, there was an error that was missed in >> parsing (the terminal shows support/Systemcall.cpp (288): Systemcall: >> 'pdflatex "newfile1.tex"' finished with exit code 1). >> - For a related email thread, see >> https://www.mail-archive.com/lyx-devel%40lists.lyx.org/msg185316.html > > I am surprised that the exit code is currently ignored.
So was I. I guess this means that our log parsing is pretty good if the issue hasn't come up before. > IMHO it can be made an error right away. I would be OK with making it an error right away. The argument for first making it a warning is that from the user perspective, the documents stop compiling. We had a similar discussion with BibTeX. We currently do not report BibTeX errors. Jurgen implemented support for reporting errors (7e188c51) but had to revert (148317b6) because of user complaints. > If you want to keep it as a warning then please don't > mention future version numbers, these tend to be wrong (we do not know if > the release after 2.2.0 will be named 2.3.0 or something else, and we don't > know either if this will be the release which converts the warning into an > error). OK I will say "future version". > I can't comment on the Alert stuff since I don't understand it too well, but > the other patches look all good. Thanks for taking a look. Scott
