Le 11/01/2016 18:54, Guillaume Munch a écrit :
Attached takes all comments into account. I hope the additional
explanations help.
OK, let's go through the patches again. I am sorry this is taking so
much time.
0001: a few remarks/questions:
- I still do not understand why the dialog, instead of using the
"for-dialog" trick, could not use directly tabular-feture to query the
status of a feature. I read your explanation, but I probably missed
something.
- in InsetTabular::getStatus, you could start with
if (cmd.getArg(0) != "tabular")
break;
to limit nesting.
- How can InsetTabular::tabularFeatures return something else than
"true" now?
- Are there places where one sets several features at once? Or is it
just that we this multi-arguments feature because the lfun is declared
like that?
- The code of InsetMathCases::doDispatch is indeed strange. I suspect
that the break after cur.undispatched() should be a return; the
recordUndo seems bogus too.
- beside this, you have my +1 on the modifications in mathed/.
000[23456]: look fine to me, but I think you already got the +1
0007: OK with the update
JMarc
