ctubbsii commented on code in PR #5866: URL: https://github.com/apache/accumulo/pull/5866#discussion_r2326215737
########## test/src/main/java/org/apache/accumulo/test/suites/SimpleSharedMacTestSuiteIT.java: ########## @@ -43,7 +43,7 @@ * IMPORTANT NOTE: Only the concrete classes should be marked with "IT_SimpleSuite". For example, * marking an abstract class will not add its implementations to the suite. */ -@Suite +@Suite(failIfNoTests = false) Review Comment: While we are excluding it for our sunny profile, this error can occur with any combination of command-line options that the user might set that results in filtering out the tests down to an empty set. Since there's no way that I can see to pass user config options to this suite to disable the default failure behavior, we have to leave this here, so we don't restrict what kinds of testing command-line options the user can set. The output will show a success, but it will also show that 0 tests were run. If we remove this, then users won't even have the option of executing certain combinations of tests, because it will always fail. Leaving it in was my compromise. Perhaps we can request a feature upstream in junit/surefire to be able to control the behavior of the suite engine with a command-line option? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
