kevinrr888 commented on code in PR #5866:
URL: https://github.com/apache/accumulo/pull/5866#discussion_r2330327019
##########
pom.xml:
##########
@@ -1529,6 +1529,13 @@
<id>sunny</id>
<properties>
<failsafe.groups>SunnyDay</failsafe.groups>
+ <!--
+ exclude junit-platform-suite engine from this list of engines to run,
+ so it skips the SimpleSuite tests, which contain no sunny tests, to
+ prevent the suite engine from running the BeforeSuite and AfterSuite
+ minicluster setup and teardown unnecessarily for zero tests
+ -->
+
<failsafe.includeJUnit5Engines>junit-jupiter</failsafe.includeJUnit5Engines>
Review Comment:
My concern would be that it may be hard for a dev to tell that this line
needs to be removed if a sunny SimpleSuite is added. Would have to notice that
the SimpleSuite test is not run when running sunny, which may go unnoticed.
Maybe just updating the `SimpleSharedMacTestSuiteIT` class comment to point
to this maven config would be sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
