ctubbsii commented on code in PR #5866:
URL: https://github.com/apache/accumulo/pull/5866#discussion_r2331546210
##########
pom.xml:
##########
@@ -1529,6 +1529,13 @@
<id>sunny</id>
<properties>
<failsafe.groups>SunnyDay</failsafe.groups>
+ <!--
+ exclude junit-platform-suite engine from this list of engines to run,
+ so it skips the SimpleSuite tests, which contain no sunny tests, to
+ prevent the suite engine from running the BeforeSuite and AfterSuite
+ minicluster setup and teardown unnecessarily for zero tests
+ -->
+
<failsafe.includeJUnit5Engines>junit-jupiter</failsafe.includeJUnit5Engines>
Review Comment:
If somebody is modifying the sunny profile to add remove tests or alter its
default behavior in some way, then this is the right place to look, so I think
this comment is sufficient. The behavior of the sunny profile is not specific
to `SimpleSharedMacTestSuiteIT`, so putting it there is not the right place for
any further comments. I'm also disinclined to add more details that are just as
likely to confuse and mislead as they are to help, because so much of the
behavior depends on precisely which command-line options are used by the user.
To explain all the possibilities of what a developer might need to change under
various different options and desired behaviors, could fill a book.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
